Add PackageFiles support for make install workflows#725
Draft
Add PackageFiles support for make install workflows#725
Conversation
Contributor
Author
|
@cpuguy83 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: cpuguy83 <799078+cpuguy83@users.noreply.github.com>
Co-authored-by: cpuguy83 <799078+cpuguy83@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [REQ] Allow
Add PackageFiles support for make install workflows
Aug 7, 2025
make install in build step to place artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for projects that use
make installor similar installation commands to place artifacts, addressing the need for a simpler way to specify package contents without manually categorizing every file.Problem
Previously, dalec required explicitly categorizing artifacts into specific types (binaries, manpages, config files, etc.). This worked well for projects that manually copy specific files, but was cumbersome for projects using standard installation mechanisms like
make install. Users had to list every single file individually in theartifactssection because of the requirement to list files in the%filesdirective in RPM specs.Solution
This PR introduces a new
package_filesfield in theArtifactsstruct that allows specifying package-specific file listings directly, letting projects use their native installation commands while still providing the necessary file lists for package creation.Usage Example
Key Features
make install, autotools, cmake, and other standard build systemsImplementation Details
PackageFiles map[string]stringfield toArtifactsstructIsEmpty()method to consider the new fieldTesting
This simplifies builds for projects following standard installation patterns while providing the fine-grained control needed for package creation.
Fixes #614.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.