feat: migrate assertions from gotest.tools to testify#915
Open
Harsh-Daga wants to merge 1 commit intoproject-dalec:mainfrom
Open
feat: migrate assertions from gotest.tools to testify#915Harsh-Daga wants to merge 1 commit intoproject-dalec:mainfrom
Harsh-Daga wants to merge 1 commit intoproject-dalec:mainfrom
Conversation
invidian
requested changes
Jan 7, 2026
Contributor
invidian
left a comment
There was a problem hiding this comment.
@Harsh-Daga Assert from gotest.tools/v3/assert will FailNow() the tests, so we should actually use github.com/stretchr/testify/require to preserve that behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates all test assertions from gotest.tools/v3/assert to github.com/stretchr/testify/assert, consolidating the codebase on a single testing library. The migration maintains full test coverage and behavior.
Implementation Details
Assertion Mapping:
Complex Comparisons:
For tests requiring cmpopts (specifically helpers_test.go), I retained google/go-cmp directly and used assert.Empty(t, cmp.Diff(expected, actual, opts)) pattern. This preserves the powerful comparison options needed for complex struct comparisons while still using testify for the assertion.
Files Migrated (24 total):
Command packages:
Root level:
Package tests:
Test directory:
Test utilities:
Testing
All existing tests continue to pass with the new assertions:
go test -short ./...
Build verification:
go build ./...
I verified that:
Notes
Fixes #913