Skip to content
This repository was archived by the owner on Feb 27, 2026. It is now read-only.

Integrating Google Analytics#73

Closed
Yoric wants to merge 3 commits intoproject-lighthouse:masterfrom
Yoric:analytics
Closed

Integrating Google Analytics#73
Yoric wants to merge 3 commits intoproject-lighthouse:masterfrom
Yoric:analytics

Conversation

@Yoric
Copy link
Copy Markdown
Contributor

@Yoric Yoric commented Feb 2, 2017

This patch introduces bindings for Google Analytics, usable in both C++, Obj-C++ and Swift.
Please use telemetry.h for your constant strings.

See GoogleService-Info.plist for the identification of the application at Google Analytics.

@Yoric Yoric requested a review from azasypkin February 2, 2017 11:42
This patch introduces bindings for Google Analytics, usable in both C++, Obj-C++ and Swift.
Please use telemetry.h for your constant strings.

See GoogleService-Info.plist for the identification of the application at Google Analytics.
@Yoric
Copy link
Copy Markdown
Contributor Author

Yoric commented Feb 2, 2017

Interesting. I had a (meaningful) build error on BB that didn't show up locally. So perhaps BB is somehow running additional checks.

@azasypkin azasypkin removed their request for review September 12, 2017 08:21
@cknowles-admin cknowles-admin added the ARCHIVED CLOSED at time of archiving label Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ARCHIVED CLOSED at time of archiving

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants