Conversation
Author
|
@miniwynne muxer.yaml should be in the cca-controls repo |
nsoblath
requested changes
Apr 10, 2025
Member
nsoblath
left a comment
nsoblath
left a comment
There was a problem hiding this comment.
Overall looks quite good. Can we please move the example .yaml files to an examples directory, or something like that? This would be a good opportunity to add it so that the top directory doesn't get overwhelmed.
…entation around line 102
wcpettus
commented
May 6, 2025
dripline/extensions/muxer_service.py
Outdated
| raise ThrowReply('message_error_invalid_method', | ||
| f'endpoint {self.name} does not support set') | ||
| __all__.append('MuxerRelay') | ||
| class MuxerRelay(Entity): |
Author
There was a problem hiding this comment.
…pop to all of them, which is also what I see in object.py (havent done it to calibration yet tho)
…ply, but also provider to service
…for endpoints, copied from phase 2 w same changes
we need simple_pid for the mainz pid loop so maybe this is a Hail Mary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of MuxerProvider and associated Entity class to dl3 version.