Conversation
wcpettus
requested changes
Feb 5, 2026
|
|
||
|
|
||
| __all__.append("HuberEntity") | ||
| class HuberEntity(Entity): |
There was a problem hiding this comment.
set is disabled - is that universal for all Huber endpoints? should this be a HuberGetEntity?
Contributor
Author
There was a problem hiding this comment.
You can set an Hiber endpoint but its ugly. I have to think about it and see if I want to implement it. Thanks for the suggestion
There was a problem hiding this comment.
just to be clear - I wasn't suggesting that you should implement the set (if it's ugly, and you don't really need it, probably not worth it); but if there later might be a get/set version, do you want the naming convention to already predict that. Otherwise in the future all of your HuberEntity usages will pick up a set functionality that you may not want (or maybe you do).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement yet another company specific service and endpoint.
For the chiller from Huber there is a set of three commands however one of the commands controls several values (get and set).
Therefore we implement the protocol from Huber.
The tool works nicely with our chiller and we can read: