ClausePresenter: don't attempt to call #display_label on a non-existant field configuration#3442
Open
sandbergja wants to merge 1 commit intomainfrom
Open
ClausePresenter: don't attempt to call #display_label on a non-existant field configuration#3442sandbergja wants to merge 1 commit intomainfrom
sandbergja wants to merge 1 commit intomainfrom
Conversation
…nt field configuration
sandbergja
added a commit
to pulibrary/orangelight
that referenced
this pull request
Nov 11, 2024
…n-existant field configuration This fixes an error that appeared when a user specified a search field that does not exist. It is essentially the same as upstream fix projectblacklight/blacklight#3442, so if that is accepted and we start using a Blacklight release that includes it, we can remove our customized version.
kevinreiss
pushed a commit
to pulibrary/orangelight
that referenced
this pull request
Nov 11, 2024
…n-existant field configuration (#4559) This fixes an error that appeared when a user specified a search field that does not exist. It is essentially the same as upstream fix projectblacklight/blacklight#3442, so if that is accepted and we start using a Blacklight release that includes it, we can remove our customized version.
jcoyne
requested changes
Nov 12, 2024
Member
jcoyne
left a comment
jcoyne
left a comment
There was a problem hiding this comment.
This handles the failure silently, but shouldn't this result in a 401 Bad Request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3441