Skip to content

fix missing prefix while listing cloud run resources #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkrs2404 merged 1 commit into from
Apr 29, 2026
Merged

fix missing prefix while listing cloud run resources #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/providers/gcp/cloud-run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"strings"

"github.com/projectdiscovery/cloudlist/pkg/schema"
"github.com/projectdiscovery/gologger"
run "google.golang.org/api/run/v1"
)

Expand Down Expand Up @@ -55,13 +56,16 @@ func (d *cloudRunProvider) getServices() ([]*run.Service, error) {
locationsService := d.run.Projects.Locations.List(fmt.Sprintf("projects/%s", project))
locationsResponse, err := locationsService.Do()
if err != nil {
gologger.Warning().Msgf("could not list cloud run locations for project %s: %s", project, err)
continue
}

for _, location := range locationsResponse.Locations {
servicesService := d.run.Projects.Locations.Services.List(location.Name)
servicesResponse, err := servicesService.Do()
// build the parent explicitly because the location.Name is not returned with the projects/ prefix in Knative API
parent := fmt.Sprintf("projects/%s/locations/%s", project, location.LocationId)
servicesResponse, err := d.run.Projects.Locations.Services.List(parent).Do()
if err != nil {
gologger.Warning().Msgf("could not list cloud run services for %s: %s", parent, err)
continue
}
services = append(services, servicesResponse.Items...)
Expand Down
Loading