Skip to content

fix: display HTTPS interactions in client output#1360

Open
c14dd49h wants to merge 1 commit intoprojectdiscovery:mainfrom
c14dd49h:fix/cli-display-https-interactions
Open

fix: display HTTPS interactions in client output#1360
c14dd49h wants to merge 1 commit intoprojectdiscovery:mainfrom
c14dd49h:fix/cli-display-https-interactions

Conversation

@c14dd49h
Copy link
Copy Markdown

@c14dd49h c14dd49h commented Apr 2, 2026

Summary

Since aab1b78 (fix: differentiate HTTP vs HTTPS protocol in interactions), the server returns "https" as the protocol for TLS interactions. The client's switch statement in main.go only handles case "http":, so HTTPS interactions are silently dropped from the output.

This is the companion fix to projectdiscovery/interactsh-web#238 which addresses the same issue on the web client side.

  • Add "https" to the "http" case in the client output switch

Test plan

  • Register a client against a v1.3.1+ server
  • Send an HTTPS request to the generated callback URL
  • Verify the interaction appears in the client output

Summary by CodeRabbit

  • Bug Fixes
    • HTTPS protocol interactions are now processed identically to HTTP interactions in CLI output. Both protocol types will undergo the same filtering checks, output formatting, and detailed request/response rendering rules, providing consistent and comprehensive behavior across all HTTP-based interaction types reported in the command-line interface.

Since aab1b78, the server returns `"https"` as the protocol for TLS
interactions. The client switch statement only handles `"http"`, so
HTTPS interactions are silently dropped from the output.

Add `"https"` to the `"http"` case to display both.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7258da22-7cb0-4f0d-b9a2-2076d5a56d8b

📥 Commits

Reviewing files that changed from the base of the PR and between 810180a and 1e0a5e0.

📒 Files selected for processing (1)
  • cmd/interactsh-client/main.go

Walkthrough

The CLI interaction output switch in the interactsh client now treats "https" protocol values alongside "http", routing both through identical filter checks and formatted output logic rather than skipping HTTPS interactions.

Changes

Cohort / File(s) Summary
Protocol Switch Enhancement
cmd/interactsh-client/main.go
Added "https" case to switch statement alongside "http" to display HTTPS interactions using the same HTTP output formatting, filter checks, and verbose request/response rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • projectdiscovery/interactsh#1355: Modifies the identical switch statement in cmd/interactsh-client/main.go to handle "https" protocol values alongside "http" for displaying HTTPS interactions in client output.

Poem

🐰 A protocol tale, both secure and plain,
HTTP danced alone in the main,
But HTTPS said, "Let me join the show!"
One switch case, and together they glow! 🌐

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: enabling HTTPS interaction display in the client output, which aligns with the changeset's purpose.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@neo-by-projectdiscovery-dev
Copy link
Copy Markdown

neo-by-projectdiscovery-dev bot commented Apr 2, 2026

Neo - PR Security Review

No security issues found

Comment @pdneo help for available commands. · Open in Neo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant