fix: display HTTPS interactions in client output#1360
fix: display HTTPS interactions in client output#1360c14dd49h wants to merge 1 commit intoprojectdiscovery:mainfrom
Conversation
Since aab1b78, the server returns `"https"` as the protocol for TLS interactions. The client switch statement only handles `"http"`, so HTTPS interactions are silently dropped from the output. Add `"https"` to the `"http"` case to display both. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CLI interaction output switch in the interactsh client now treats Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Neo - PR Security ReviewNo security issues found Comment |
Summary
Since aab1b78 (
fix: differentiate HTTP vs HTTPS protocol in interactions), the server returns"https"as the protocol for TLS interactions. The client's switch statement inmain.goonly handlescase "http":, so HTTPS interactions are silently dropped from the output.This is the companion fix to projectdiscovery/interactsh-web#238 which addresses the same issue on the web client side.
"https"to the"http"case in the client output switchTest plan
Summary by CodeRabbit