move the client logic out of main pkg so it can be reused.#191
Open
SagiROosto wants to merge 4 commits intoprometheus-community:masterfrom
Open
move the client logic out of main pkg so it can be reused.#191SagiROosto wants to merge 4 commits intoprometheus-community:masterfrom
SagiROosto wants to merge 4 commits intoprometheus-community:masterfrom
Conversation
1a5fba8 to
7efcbc0
Compare
Author
|
hey @SuperQ, can you take a look? |
Author
|
Happy Birthday to the PR 🎂🥳 |
SuperQ
reviewed
Nov 26, 2025
SuperQ
reviewed
Nov 26, 2025
end-to-end-test.sh
Outdated
| done | ||
|
|
||
| ./pushprox-client --log.level=debug --proxy-url=http://localhost:8080 & | ||
| ./pushprox-client --log.level=debug --proxy-url=http://localhost:8080 --fqdn $(hostname) & |
Author
There was a problem hiding this comment.
I probably failed my tests but now it pass so I reverted it
SuperQ
requested changes
Nov 26, 2025
Contributor
|
Seems mostly fine. A couple questions. |
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Author
|
@SuperQ yea you got a point I reverted these odd changes and now it simply work as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Prometheus Pushprox client to move its core logic outside the main package, enabling it to be reused as a library in other projects. The primary motivation behind this change is to allow projects to integrate the proxy client directly into existing components, reducing the resource footprint significantly compared to running it as a standalone Docker container or binary.
Motivation
The original implementation of the Pushprox client was designed to run as a dedicated Docker container or a binary. While this works well in many scenarios, it introduces unnecessary overhead for projects that already have a metrics or health component and simply need to integrate the proxy client.
In my use case—likely shared by many others, especially in resource-constrained environments such as IoT devices—this overhead is critical. Running the client as part of an existing component saves resources and simplifies deployment without sacrificing functionality.
Changes
Benefits
Impact