Add labels functionality for service discovery #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85
This could also be used to solve #160.
This works as intended when running the end-to-end tests and keeps backwards-compatibility.
I'd have some tests for
addKnownClient()andKnownClients()that verify thataddKnownClient()with different label sets actually update the labels for that clientAnd some tests for the request handling and JSON parsing.
Let me know if you're interested in adding those too.
Would be cool to see this in a next release so we don't have to rely on the custom build. 🙂