Skip to content

Conversation

@moreinhardt
Copy link

@moreinhardt moreinhardt commented Jan 27, 2026

Closes #85

This could also be used to solve #160.


This works as intended when running the end-to-end tests and keeps backwards-compatibility.

I'd have some tests for addKnownClient() and KnownClients() that verify that

  • this works with labels as well as without
  • expired clients are filtered
  • repeated calls to addKnownClient() with different label sets actually update the labels for that client

And some tests for the request handling and JSON parsing.

Let me know if you're interested in adding those too.


Would be cool to see this in a next release so we don't have to rely on the custom build. 🙂

Signed-off-by: Moritz Reinhardt <moreinhardt@gmail.com>
@moreinhardt
Copy link
Author

I did not change the circleci job that only scrapes one client in the end-to-end tests. So I had to revert my change that expects two metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify target labels for relabeling via /clients

1 participant