Open
Conversation
hansmi
suggested changes
Jan 5, 2021
added 2 commits
January 11, 2021 13:56
This replaces having the FQDN in the body in order to make client certificate validation easier. The proxy will continue to work with older clients as we still keep the old endpoint. However any calls to `/poll/*` will use the FQDN provided in the URL for registration. Signed-off-by: Linus Wallgren <linus@nectarinehealth.com>
It needs to be cryptographically unique so that each client is uniquely identified and cannot be mistaken with another client. If it is not cryptographically unique one client could potentially guess the ID and thus send data as if it is was another client. Signed-off-by: Linus Wallgren <linus@nectarinehealth.com>
hansmi
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces having the FQDN in the body in order to make client
certificate validation easier.
The proxy will continue to work with older clients as we still keep the
old endpoint. However any calls to
/poll/*will use the FQDN providedin the URL for registration.
With this change it is easy to compare the CN in the client certificate with the FQDN provided to PushProx to ensure the client is authorized.
The push call needs not change as the Id header uses a UUID that, to my understanding, is cryptographically random.