Histogram spec: Rework and amend operators section#2823
Conversation
beorn7
force-pushed
the
beorn7/histogram
branch
from
1e4e058 to
fb815fc
Compare
|
Now that we have nailed down what to do in prometheus/prometheus#17904 , we can finalize this. @krajorama & @linasm what do you think about this? I'm wondering how detailed we should describe the edge cases in the spec (or pseudo-spec, as I prefer to call it) here. One could argue that they are all implied with the current wording, but another line of argument would say we should spell out the edge cases here explicitly. (I currently tend towards the former, as it is more in line with the other parts of this document.) |
|
As per discussion over on prometheus/prometheus#17904, I'll add a detailed edge case description here (hopefully tomorrow). |
beorn7
force-pushed
the
beorn7/histogram
branch
from
fb815fc to
e017e1d
Compare
|
I think the current version should cover all edge cases. @krajorama @linasm please verify. |
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
looks good over all, made two suggestions
- Divide operators section into sub-sections and reformat accordingly. - Add that negative results of multiplication count as gauge histogram. - Improve and complete the sub-section about interpolation. - Correct and complete the sub-section about trim operators. Signed-off-by: beorn7 <beorn@grafana.com>
beorn7
force-pushed
the
beorn7/histogram
branch
from
82ec659 to
dc4ee03
Compare
|
Done. PHAL. |
2 participants
Divide operators section into sub-sections and reformat accordingly.
Add that negative results of multiplication count as gauge histogram.
Correct and complete the sub-section about trim operators.