fix(collector): handle EINVAL errors from thermal_zone gracefully#3657
Open
superShen0916 wants to merge 1 commit into
Open
fix(collector): handle EINVAL errors from thermal_zone gracefully#3657superShen0916 wants to merge 1 commit into
superShen0916 wants to merge 1 commit into
Conversation
When running node_exporter in Docker on some embedded devices, reading thermal_zone temp files can return EINVAL (invalid argument) errors. These were previously not handled, causing the entire thermal_zone collector to fail. Add syscall.EINVAL to the list of errors that cause the collector to return ErrNoData instead of failing entirely. Fixes prometheus#2980 Signed-off-by: shenpeng.sp0916 <shenpeng.sp0916@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2980 - When running node_exporter in Docker on some embedded devices, reading thermal_zone temp files can return
EINVAL(invalid argument) errors. These were previously not handled, causing the entire thermal_zone collector to fail with an error instead of gracefully returningErrNoData.Changes
collector/thermal_zone_linux.go: Addedsyscall.EINVALto the list of handled errors that result inErrNoDatainstead of propagating as a fatal collector errorTest plan
go build ./collector/succeeds