collector: scope collector runtime state#3664
Draft
nicolastakashi wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
5ed0571 to
f2d8a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This continues the incremental refactor to make
node_exportereasier to embed outside the standalone binary.The broader goal is to support ongoing work to make Prometheus exporters embeddable inside the Prometheus OpenTelemetry Collector distribution as native receivers, without requiring each exporter to be rewritten as an OpenTelemetry component.
This PR builds on the previous config, runtime, and CLI wiring PRs by moving collector runtime state off shared process-global mutation and into runtime-owned state.
Specifically, this PR:
cpufreq-related behaviorWhy
The goal of this change is to make collector setup more instance-scoped and less dependent on mutable process-global state.
Before this change, runtime construction could mutate global collector enablement, and collector instances were cached globally across the process. That made it harder to reason about independent runtime instances and made filtered handler construction depend on shared global state.
After this change, collector enablement is resolved once into runtime-local state, collector instances are cached within that runtime state, and derived filtered runtimes reuse the base runtime's effective collector configuration.
This is still not the end of the embeddability work. Many individual collectors still read configuration directly from package-global CLI flags. The intent of this PR is to narrow the shared runtime state surface and make the current runtime model more explicit and reusable.
Stack
This PR is part of a stacked series:
The earlier PRs introduced reusable config, runtime, and binary wiring layers. This PR pushes the remaining runtime behavior further away from shared process-global mutation.