Add failing tests for #505: DEFAULT_STRENGTH inconsistency#529
Draft
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Draft
Add failing tests for #505: DEFAULT_STRENGTH inconsistency#529prompt-driven-github[bot] wants to merge 1 commit intomainfrom
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Conversation
Add unit and E2E tests that detect stale hardcoded DEFAULT_STRENGTH values across cli.py (0.75), llm_invoke.py (0.5), and executor.py (0.5) which should all reflect the canonical value of 1.0 from pdd/__init__.py. Also fix prompt template generate_pddrc_YAML.prompt which referenced the stale 0.75 default in 3 places. Tests are verified to fail on current code and will pass once the code bug is fixed. Fixes #505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing tests that detect the bug reported in #505 — stale hardcoded
DEFAULT_STRENGTHvalues across multiple files that don't match the canonical1.0inpdd/__init__.py.Test Files
tests/core/test_cli.py,tests/test_llm_invoke.py,tests/server/test_executor.pytests/test_e2e_issue_505_default_strength.pyPrompt Files
pdd/templates/generic/generate_pddrc_YAML.prompt(updated 3 stale0.75→1.0)What This PR Contains
cli.py,llm_invoke.py, andexecutor.pygenerate_pddrc_YAML.prompt(prompt defect from Step 5.5)Root Cause
The
DEFAULT_STRENGTHconstant was incrementally updated from0.5 → 0.75 → 1.0over time, but hardcoded string literals and fallback values incli.py(0.75),llm_invoke.py(0.5), andexecutor.py(0.5) were never updated to match. There is no mechanism to derive user-facing default descriptions from the constant — each location independently hardcodes a stale numeric literal.Next Steps
pdd/core/cli.py:220,pdd/llm_invoke.py:1657,pdd/server/executor.py:16)Fixes #505
Generated by PDD agentic bug workflow