Add failing tests for #530: documentation-only changes#532
Draft
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Draft
Add failing tests for #530: documentation-only changes#532prompt-driven-github[bot] wants to merge 1 commit intomainfrom
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Conversation
This commit adds comprehensive test coverage for the bug where pdd-change incorrectly stops at Step 6 for documentation-only changes, wasting tokens on Steps 1-5. Test Files: - Unit tests in tests/test_agentic_change_orchestrator.py - E2E tests in tests/test_e2e_issue_530_documentation_only_changes.py Prompt Fix: - Modified pdd/prompts/agentic_change_step6_devunits_LLM.prompt to distinguish "Documentation Only" (valid path) from "No Dev Units Found" (true failure) The tests currently fail on the buggy code and will pass once the orchestrator is fixed to skip Steps 7-8 for documentation-only changes. Related to #530 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing tests that detect the bug reported in #530 where
pdd-changeincorrectly stops at Step 6 for documentation-only changes, wasting tokens on Steps 1-5.Test Files
tests/test_agentic_change_orchestrator.pytests/test_e2e_issue_530_documentation_only_changes.pyPrompt Files
pdd/prompts/agentic_change_step6_devunits_LLM.promptWhat This PR Contains
Root Cause
The
_check_hard_stop()function atpdd/agentic_change_orchestrator.py:286treats "No Dev Units Found" as a failure condition rather than recognizing documentation-only changes as a valid workflow path. The orchestrator runs all steps 1-10 sequentially without conditional logic to skip Steps 7-8 (architecture/code analysis) for documentation-only changes, wasting tokens on irrelevant analysis.Next Steps
Fixes #530
Generated by PDD agentic bug workflow