Add failing tests for #533: Orchestrator doesn't validate duplicate issue resolution status#534
Draft
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Draft
Add failing tests for #533: Orchestrator doesn't validate duplicate issue resolution status#534prompt-driven-github[bot] wants to merge 1 commit intomainfrom
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
Conversation
This commit adds comprehensive test coverage to detect the bug where the orchestrator blindly trusts LLM duplicate detection without validating that the original issue is actually resolved. Tests added: - tests/test_issue_533_duplicate_validation.py: Unit tests (10 tests) - tests/test_e2e_issue_533_duplicate_validation.py: E2E tests (3 tests) The tests correctly fail on the current code, demonstrating the bug at pdd/agentic_bug_orchestrator.py:441 where the hard stop is triggered without checking if the original issue is resolved. Related to #533 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing tests that detect the bug reported in #533 where the orchestrator blindly trusts LLM duplicate detection without validating that the original issue is actually resolved.
Test Files
tests/test_issue_533_duplicate_validation.py(10 tests)tests/test_e2e_issue_533_duplicate_validation.py(3 tests)What This PR Contains
Root Cause
The bug is at
pdd/agentic_bug_orchestrator.py:441where the orchestrator checks for the string "Duplicate of #" but doesn't validate whether the original issue is actually resolved. When the LLM fails to follow prompt instructions and outputs "Duplicate of #520" even though #520 is still OPEN, the orchestrator incorrectly triggers a hard stop and closes the duplicate issue.Test Results on Current Code
Next Steps
pdd/agentic_bug_orchestrator.py:441Fixes #533
Generated by PDD agentic bug workflow