Skip to content

refactor(ci): add shared ci success #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbeckwith-oai merged 1 commit into from
Mar 23, 2026
Merged

refactor(ci): add shared ci success #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/promptfoo-code-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Promptfoo Code Scan

on:
pull_request:
types: [opened]
types: [opened, synchronize, reopened]

jobs:
security-scan:
Expand All @@ -24,3 +24,20 @@ jobs:
min-severity: medium
guidance: |
- Always comment on a block of code—never just a single line. And always make sure the start line comes before the end line.

ci-success:
name: CI Success
runs-on: ubuntu-latest
needs: [security-scan]
if: always()
timeout-minutes: 5
permissions:
checks: read
statuses: read

steps:
- name: Wait for all PR checks to succeed
uses: promptfoo/.github/.github/actions/ci-success@main
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin ci-success action to an immutable revision

Avoid referencing promptfoo/.github/.github/actions/ci-success with @main. A mutable branch means any future upstream change (or compromise) can silently alter this repo’s CI behavior and required-check outcome. This is a supply-chain integrity risk in the workflow itself; pin to a full commit SHA (or another immutable ref) and update deliberately.

Useful? React with 👍 / 👎.

with:
github-token: ${{ secrets.GITHUB_TOKEN }}
timeout-seconds: 300
Loading