fix: mark malformed TFLite scans inconclusive#916
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 3 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Performance BenchmarksCompared Top improvements:
|
…-boundary-audit # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4e0ce8914
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def _mark_inconclusive_scan_result(result: ScanResult, reason: str) -> None: | ||
| result.metadata["scan_outcome"] = INCONCLUSIVE_SCAN_OUTCOME |
There was a problem hiding this comment.
Preserve cacheability for malformed TFLite outcomes
Setting scan_outcome to inconclusive here makes malformed TFLite results non-cacheable under cache_policy.should_cache_scan_result(...). That means the second run will rescan instead of hitting cache, so the new cached-rerun behavior/coverage is not actually implemented and repeated malformed-file scans pay full cost each time.
Useful? React with 👍 / 👎.
Summary
Validation