support for publish v2 for larger publish payload size#271
Open
mohitpubnub wants to merge 6 commits intomasterfrom
Open
support for publish v2 for larger publish payload size#271mohitpubnub wants to merge 6 commits intomasterfrom
mohitpubnub wants to merge 6 commits intomasterfrom
Conversation
mohitpubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
added 2 commits
February 16, 2026 15:14
…s not needed add headers in case of POST request when header is not for content header, add such header for Http request
Contributor
jakub-grzesiowski
left a comment
jakub-grzesiowski
left a comment
There was a problem hiding this comment.
One comment, other than that LGTM
| // 155 bytes covers the fixed overhead from base URL components and | ||
| // middleware-injected query params: scheme, origin, path separators, | ||
| // uuid, pnsdk, requestid, instanceid, and timestamp. | ||
| int estimatedSize = 155; |
Contributor
There was a problem hiding this comment.
is there a chance this could change in the future and should be dynamically calculated instead?
Contributor
Author
There was a problem hiding this comment.
Due to design of a common API execution flow, In the Endpoint class only that endpoint related path and query segments added. The common query param values are being added in later stage of API execution.
If we try to get all those params here then It would be good amount of code duplication.
Yes, In future, the design can be better to have those values dynamically calculated.
added 2 commits
February 24, 2026 00:04
new tests added for message size exceeding 2MiB verification at parameter validation level. increase request timeout default value for non subscribe http request so that history api can have more time to download the content
mohitpubnub
added
status: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support higher message payload size for publish.