Skip to content

feat/dataSync #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mohitpubnub wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat/dataSync #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dad9aca
handling error parsing scenario for dataSync endpoints error details …
Mar 30, 2026
1679c35
enahnce transport module for making http PUT requests, required for d…
Mar 30, 2026
a8d0d73
fix lint error in request.ts
Mar 30, 2026
cd73f80
chore: add CodeRabbit configuration for automated PR reviews
Apr 7, 2026
9c94118
Merge branch 'master' into CLEN-3287
mohitpubnub Apr 22, 2026
784cb05
asertive code rabbit profile with a simple create dataSync endpoint i…
May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
language: en-US

reviews:
<<<<<<< Updated upstream
=======
profile: "assertive" #more feedback
# Review draft PRs so we get early feedback
drafts: true

>>>>>>> Stashed changes
Comment on lines +6 to +12
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Resolve merge-conflict markers before merge.

Lines 6-12 and Line 104-Line 109 contain unresolved Git conflict markers, and the YAML cannot be parsed (could not find expected ':').

Proposed fix (resolve conflicts and remove markers) 
 reviews:
-<<<<<<< Updated upstream
-=======
   profile: "assertive"  `#more` feedback
-  # Review draft PRs so we get early feedback
-  drafts: true
-
->>>>>>> Stashed changes
   # Enable high-level summary of changes
   high_level_summary: false
@@
-<<<<<<< Updated upstream
-=======
   # Unrelated working directories (not part of the SDK source)
   - "!docs/**"
-
->>>>>>> Stashed changes

Also applies to: 104-109

🧰 Tools
🪛 YAMLlint (1.38.0)

[error] 7-7: syntax error: could not find expected ':'

(syntax)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.coderabbit.yaml around lines 6 - 12, The .coderabbit.yaml contains
unresolved Git conflict markers (<<<<<<<, =======, >>>>>>>) around the
profile/drafts blocks; remove the conflict markers and merge the intended keys
(e.g., keep profile: "assertive" and drafts: true or whichever variant is
correct), ensure there are no duplicate/conflicting entries in both locations
(the other conflict at lines 104-109), and validate the YAML (ensure proper
colon/value syntax and indentation) so the file parses cleanly.

# Enable high-level summary of changes
high_level_summary: false

Expand Down Expand Up @@ -94,6 +101,12 @@ path_filters:
# Dependencies
- "!node_modules/**"

<<<<<<< Updated upstream
=======
# Unrelated working directories (not part of the SDK source)
- "!docs/**"

>>>>>>> Stashed changes
# Lock files - too noisy, low review value
- "!package-lock.json"

Expand Down
4 changes: 2 additions & 2 deletions .mocharc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"require": "tsx",
"file": ["test/setup-why.ts"],
"spec": "test/**/*.test.ts",
"spec": "test/integration/endpoints/dataSync.test.ts",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Do not narrow global spec to a single test file.

Line 4 now limits CI to one integration test and effectively skips the rest of the suite.

Proposed fix 
-  "spec": "test/integration/endpoints/dataSync.test.ts",
+  "spec": "test/**/*.test.ts",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"spec": "test/integration/endpoints/dataSync.test.ts",
"spec": "test/**/*.test.ts",
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.mocharc.json at line 4, The .mocharc.json "spec" value was narrowed to a
single file which skips the rest of CI tests; update the "spec" key in
.mocharc.json to the repository's test suite glob (restore the original pattern
used for running all tests) instead of the single-file path so the full
integration/unit test suite runs in CI.

"exclude": [
"test/dist/*.{js,ts}",
"test/feature/*.{js,ts}",
"test/integration/shared-worker/*.{js,ts}"
],
"timeout": 5000,
"timeout": 5000000,
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Reduce the test timeout to a sane bound.

Line 10 sets ~83 minutes per test, which can hide hangs and slow feedback loops significantly.

Proposed fix 
-  "timeout": 5000000,
+  "timeout": 30000,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"timeout": 5000000,
"timeout": 30000,
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.mocharc.json at line 10, The mocha config currently sets the "timeout"
value to 5000000 (≈83 minutes); change the "timeout" property in .mocharc.json
to a much smaller, sane value (for example 20000 for 20s or 5000 for 5s) to
avoid hiding hangs and speed up feedback loops, then run the test suite (or CI)
to ensure the new timeout is sufficient and adjust as needed.

"reporter": "spec"
}
Loading
Loading