Conversation
There was a problem hiding this comment.
I'm torn. Some of the reworking is a good idea, but some of it just feels like moving things around. Would it be OK if I just took the feedback to heart and incorporated some of these changes in a different PR?
EDIT: At any rate, I'd be making the changes over at the documentation repo, since that's where the docs officially live now.
| If this is the first package you are publishing, the `pulsar -p publish` command | ||
| may prompt you for your GitHub username and password. If you have two-factor | ||
| authentication enabled, use a [personal access token](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/) | ||
| in lieu of a password. This is required to publish and you only need to enter | ||
| this information the first time you publish. The credentials are stored securely | ||
| in your [keychain](<https://en.wikipedia.org/wiki/Keychain_(software)>) once you | ||
| login. |
There was a problem hiding this comment.
This information is removed and there isn't any other addition that replaces it. Do you feel it is somehow inaccurate?
There was a problem hiding this comment.
these information are outdated:
- e.g. user/pwd is not possible anymore
- the publish command does NOT prompt for authentication, it needed to be done separately with the
logincommand, as explained above
if we want to be picky, maybe the keychain information could stay, tbh I get a new token every time I need to publish, and, looking at my keychain, there's no track of saved pulsar keys, so maybe that feat isn't working anymore?
|
Sorry, reviewed the wrong PR. Closing this one now that we've moved the docs, but I'll give |
|
@savetheclocktower ok, I already addressed the issues in the meantime 🥲 . let's do the same on the other repo |
2 participants
Improve and update "publishing" section, specifically it adds some docs for the
loginpartcloses #296