Skip to content

perf: parallelise rivet head oracle and base validate runs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avrabe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: parallelise rivet head oracle and base validate runs #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions src/ai-review.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,13 @@ async function reviewPullRequest(octokit, owner, repo, prNumber) {
: path.resolve(__dirname, '..', rivetCfg.binary_path);
try {
if (headSha && (await hasRivetYaml(octokit, owner, repo, headSha))) {
oracleSummary = await withTempRepoCheckout(
// Run head oracle and base validate in parallel — they are
// independent (different tarballs, different cwds, different
// commands). Sequential they cost ~2× tarball-fetch + 2× extract +
// 2× rivet runtime; parallel halves wall-time. Each side has its
// own try/catch so a base-ref failure (e.g. base SHA gone, schema
// drift) gracefully degrades to head-only findings.
const headPromise = withTempRepoCheckout(
octokit,
owner,
repo,
Expand All @@ -432,30 +438,31 @@ async function reviewPullRequest(octokit, owner, repo, prNumber) {
timeout: rivetCfg.timeout_ms || 60000
})
);
let headOracleFindings = oracleSummary?.findings || [];

// Delta filter: subtract findings already present at the PR base.
// Without this, the review surfaces the entire repo backlog every
// time (see spar#175 — 91 pre-existing warnings drowning the diff).
let baseValidate = null;
if (baseSha && baseSha !== headSha) {
try {
baseValidate = await withTempRepoCheckout(
const basePromise = (baseSha && baseSha !== headSha)
? withTempRepoCheckout(
octokit,
owner,
repo,
baseSha,
(repoPath) => runRivetValidate(resolvedBinary, repoPath, {
timeout: rivetCfg.timeout_ms || 60000
})
);
} catch (err) {
getLogger().warn(
{ pr: prNumber, err: err.message },
'base-ref validate failed — falling back to head-only oracle findings'
);
}
}
).catch((err) => {
getLogger().warn(
{ pr: prNumber, err: err.message },
'base-ref validate failed — falling back to head-only oracle findings'
);
return null;
})
: Promise.resolve(null);

const [headResult, baseValidate] = await Promise.all([
headPromise,
basePromise
]);
oracleSummary = headResult;
let headOracleFindings = oracleSummary?.findings || [];
const droppedCount = headOracleFindings.length;
headOracleFindings = subtractFindings(
headOracleFindings,
Expand Down
Loading