Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

## Optimisations

- [#925](https://github.com/pybop-team/PyBOP/pull/925) - Add `UnboundedDistribution` and the `get_transformed_distribution` functionality.

## Bug Fixes

- [#915](https://github.com/pybop-team/PyBOP/pull/915) - Fixes axis labels for non-standard domain names, adds `Dataset` length property and adds `kind` property to `Interpolant`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,9 @@
"problem.parameters[\"Positive electrode active material volume fraction\"] = (\n",
" pybop.Parameter(\n",
" initial_value=old_param.initial_value,\n",
" bounds=old_param.bounds,\n",
" distribution=pybop.LogUniform(\n",
" lower=old_param.bounds[0], upper=old_param.bounds[1]\n",
" ),\n",
" transformation=pybop.LogTransformation(),\n",
" )\n",
")\n",
Expand Down
2 changes: 0 additions & 2 deletions examples/scripts/getting_started/maximum_a_posteriori.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,10 @@
"Negative electrode active material volume fraction": pybop.Parameter(
distribution=pybop.Uniform(0.3, 0.8),
initial_value=0.653,
transformation=pybop.LogTransformation(),
),
"Positive electrode active material volume fraction": pybop.Parameter(
distribution=pybop.Uniform(0.3, 0.8),
initial_value=0.657,
transformation=pybop.LogTransformation(),
),
}
)
Expand Down
5 changes: 3 additions & 2 deletions examples/scripts/getting_started/monte_carlo_sampling.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import numpy as np
import pybamm

import pybop
Expand Down Expand Up @@ -32,11 +33,11 @@
parameter_values.update(
{
"Negative electrode active material volume fraction": pybop.Parameter(
distribution=pybop.Gaussian(0.68, 0.02),
distribution=pybop.LogNormal(np.log(0.68), 0.02),
transformation=pybop.LogTransformation(),
),
"Positive electrode active material volume fraction": pybop.Parameter(
distribution=pybop.Gaussian(0.65, 0.02),
distribution=pybop.LogNormal(np.log(0.65), 0.02),
transformation=pybop.LogTransformation(),
),
}
Expand Down
2 changes: 1 addition & 1 deletion pybop/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# Parameter classes
#
from .parameters.parameter import Parameter, Parameters
from .parameters.distributions import Distribution, Gaussian, Uniform, Exponential, JointDistribution
from .parameters.distributions import Distribution, Exponential, Gaussian, JointDistribution, LogNormal, LogUniform, Unbounded, Uniform
from .parameters.multivariate_distributions import MultivariateNonparametric, MultivariateUniform, MultivariateGaussian, MultivariateLogNormal, MarginalDistribution

#
Expand Down
2 changes: 0 additions & 2 deletions pybop/optimisers/base_optimiser.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ def run(self) -> "OptimisationResult":
results = []
for i in range(self._multistart):
if i >= 1:
if self.problem.parameters.distribution is None:
raise RuntimeError("Distributions must be provided for multi-start")
initial_values = self.problem.parameters.sample_from_distribution(1)[0]
self.problem.parameters.update(initial_values=initial_values)
self._set_up_optimiser()
Expand Down
Loading
Loading