Skip to content

Rename Sobol sensitivity method#938

Open
NicolaCourtier wants to merge 1 commit intodevelopfrom
rename-sobol-sensitivities
Open

Rename Sobol sensitivity method#938
NicolaCourtier wants to merge 1 commit intodevelopfrom
rename-sobol-sensitivities

Conversation

@NicolaCourtier
Copy link
Copy Markdown
Member

Description

Add a check for finite bounds and specify the method by renaming sensitivity_analysis to get_sobol_sensitivities.

Fixes #657

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (4628a65) to head (d6b76ca).
⚠️ Report is 49 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #938      +/-   ##
===========================================
+ Coverage    89.41%   92.86%   +3.44%     
===========================================
  Files           63       73      +10     
  Lines         4857     5690     +833     
===========================================
+ Hits          4343     5284     +941     
+ Misses         514      406     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NicolaCourtier
Copy link
Copy Markdown
Member Author

Alternatively, we can deprecate the function and move SALib into the optional dependencies, as SALib is only used directly in the examples. What do you think @Dibyendu-IITKGP ?

"""

bounds_array = problem.parameters.get_bounds_array()
if not np.isfinite(bounds_array).all():
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not np.isfinite(bounds_array).all():
if np.any(~np.isfinite(bounds_array)):

nit: minor optimisation where we short-circuit as soon as it hits the first True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Global Sensitivities struggle with non-bounded parameters

2 participants