Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
+ Coverage 89.41% 90.88% +1.47%
===========================================
Files 63 73 +10
Lines 4857 5686 +829
===========================================
+ Hits 4343 5168 +825
- Misses 514 518 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agriyakhetarpal
left a comment
There was a problem hiding this comment.
LGTM, thanks @NicolaCourtier!
Side note: I was looking through the trove classifiers we list, and we have "Development Status :: 3 - Alpha" (which I feel is a bit outdated, considering we've at least moved into a "Development Status :: 4 - Beta" at this point, given the JOSS paper), and we have "License :: OSI Approved :: BSD License", which is now deprecated and discouraged in favour of PEP 639 that offers better licensing metadata. Would you like me to update them in another PR?
|
Oh, yes! Please do @agriyakhetarpal |
Description
Extend support to Python 3.14.
Fixes #939
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)nox -s testsnox -s doctest