Skip to content

Fix CPU flags in psydac/api/settings.py#569

Merged
yguclu merged 12 commits intodevelfrom
cpu_flag-M4-patch
Feb 19, 2026
Merged

Fix CPU flags in psydac/api/settings.py#569
yguclu merged 12 commits intodevelfrom
cpu_flag-M4-patch

Conversation

@campospinto
Copy link
Copy Markdown
Collaborator

@campospinto campospinto commented Jan 29, 2026

Clean up platform-specific flags for GCC compilers. In particular, do not use the plausible but inexistent flag -mcpu=apple-m4 on Apple M4 computers (which use ARM chips). Instead, always use -march=native, and additionally -mavx on x86_64 architectures. Further, do not use -mtune=native as this is not always supported. These changes fix #568

@campospinto campospinto self-assigned this Jan 29, 2026
Comment thread psydac/api/settings.py Outdated
Comment thread psydac/api/settings.py Outdated
Comment thread psydac/api/settings.py
@yguclu yguclu added testing Unit tests, coverage, benchmarks Next Release Must be in next release labels Jan 30, 2026
@campospinto campospinto marked this pull request as draft February 10, 2026 16:44
@campospinto campospinto marked this pull request as ready for review February 10, 2026 16:45
@campospinto campospinto marked this pull request as draft February 10, 2026 16:48
@campospinto campospinto marked this pull request as ready for review February 10, 2026 16:48
@campospinto campospinto marked this pull request as draft February 11, 2026 10:35
@campospinto campospinto marked this pull request as ready for review February 11, 2026 10:35
@campospinto campospinto marked this pull request as draft February 11, 2026 10:45
@campospinto campospinto marked this pull request as ready for review February 11, 2026 10:45
@campospinto campospinto marked this pull request as draft February 11, 2026 10:57
@campospinto campospinto marked this pull request as ready for review February 11, 2026 10:57
@campospinto campospinto marked this pull request as draft February 11, 2026 11:23
@campospinto campospinto marked this pull request as ready for review February 11, 2026 11:24
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Feb 11, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4f78a33) 31801 19597 61.62%
Head commit (77025d1) 63576 (+31775) 39174 (+19577) 61.62% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#569) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@campospinto campospinto marked this pull request as draft February 18, 2026 14:06
@campospinto campospinto marked this pull request as ready for review February 18, 2026 14:06
@campospinto campospinto marked this pull request as draft February 18, 2026 14:06
@campospinto campospinto marked this pull request as ready for review February 18, 2026 14:07
Copy link
Copy Markdown
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR!

This looks good to me now, I just have two minor comments

Comment thread psydac/api/settings.py Outdated
Comment thread psydac/api/settings.py Outdated
Commented out unused imports and code related to gfortran version checking and platform-dependent flags.
Comment thread psydac/api/settings.py Outdated
Comment thread psydac/api/settings.py Outdated
Removed unclear comments and useless hack
@yguclu yguclu marked this pull request as draft February 19, 2026 13:50
@yguclu yguclu marked this pull request as ready for review February 19, 2026 13:50
@yguclu yguclu changed the title Fix CPU flag for Apple M4 in settings.py Fix CPU flags in psydac/api/settings.py Feb 19, 2026
@yguclu yguclu enabled auto-merge (squash) February 19, 2026 14:02
@yguclu yguclu merged commit bc87faa into devel Feb 19, 2026
10 checks passed
@yguclu yguclu deleted the cpu_flag-M4-patch branch February 19, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Next Release Must be in next release testing Unit tests, coverage, benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong cpu flag for Apple M4 chips

3 participants