Closed
Conversation
- Downgrade jenkinsbase.get_data from ERROR to WARNING; raise_for_status propagates the exception to callers, making the pre-emptive ERROR log redundant and misleading for transient startup/restart failures - Downgrade fingerprint.valid from WARNING to INFO and use module logger; a 404 on the fingerprint endpoint simply means fingerprints are disabled - Downgrade artifact.save from WARNING to INFO; ArtifactBroken during verify falls through to a re-download, so it is not an error condition - Poll /api/python?tree=jobs[name,color,url] in ensure_jenkins_up instead of root URL, ensuring the API is fully ready before cleanup begins - Catch per-job exceptions in _delete_all_jobs so a 404 on one job (deleted between list and delete) does not abort the whole cleanup
- fingerprint.py: on 404, enable fingerprints via Groovy script and retry instead of just logging that they are disabled - docker_jenkins.py: remove HTTPAdapter/Retry session in wait_for_ready (retry loop handles transient failures), handle NotFound before APIError in stop() to avoid spurious warnings when container is already gone
Adds test-macos and test-windows jobs to CI_TEST workflow. - test-macos: full suite (unit + systests) on Python 3.10/3.13 using Colima-backed Docker and Homebrew krb5 - test-windows: unit tests always; systests attempted after switching Docker Desktop to Linux container mode (continue-on-error until stability is validated)
Up to standards ✅🟢 Issues
|
On a 404 (fingerprints disabled), default behavior now logs at INFO and sets unknown=True without mutating Jenkins config. Callers that want to auto-enable pass enable_if_disabled=True to valid().
macOS: remove Docker/systests setup. GitHub Actions macOS runners do not expose the Hypervisor Framework to nested processes, so Lima/QEMU aborts with HV_UNSUPPORTED. Unit tests provide cross-platform coverage; systests are covered by the Linux build job. Windows: remove MIT Kerberos install. requests-kerberos on Windows uses winkerberos (Windows SSPI) — no system Kerberos library is needed and choco install mitkerberos exits 3010 (reboot required) which fails the job. Remove Docker/systests steps for the same reason as macOS.
clintonsteiner
added a commit
to clintonsteiner/jenkinsapi
that referenced
this pull request
Apr 14, 2026
Consolidates 3 PRs into a single, mergeable change: ## CI Changes - Add test-macos job: runs unit tests on Python 3.10/3.13 using native krb5 (no Docker due to GitHub Actions macOS runners not exposing Hypervisor Framework) - Add test-windows job: runs unit tests on Python 3.10/3.13 using native SSPI (no Docker due to unreliable Linux container support on Windows CI runners) - Both jobs skip Docker-based systests; those remain covered by Linux build job - Pure-Python unit tests provide cross-platform validation ## Code Changes - Add enable_if_disabled parameter to Fingerprint.valid() method - Auto-enable fingerprints on 404 (disabled) when opt-in flag is True - Default behavior logs at INFO level without mutating Jenkins configuration - Includes test coverage for both 404 scenarios (default and opt-in) Based on best pieces from: - PR pycontribs#1115: ci/consolidate-windows-macos-testing - PR pycontribs#1125: feat/ci-mac-windows - PR pycontribs#1129: ci/consolidate-macos-windows-testing Fixes macOS and Windows CI without complexity from attempted Docker setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.