Replace socketpair write bench with deterministic partial-send microbench#958
Closed
Kludex wants to merge 1 commit into
Closed
Replace socketpair write bench with deterministic partial-send microbench#958Kludex wants to merge 1 commit into
Kludex wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_bench_sync_stream_write_largeused a realsocket.socketpair()and a draining reader thread. In practice the kernel accepted most sends in one go, so the buffer-slicing loop insideSyncStream.writeran only a handful of times. That meant optimisations targeting that loop (e.g. perf: use memoryview in write() to avoid copies #954) did not produce a detectable delta on CodSpeed.test_bench_sync_stream_write_microcopy, which drivesSyncStream.writethrough a_PartialSendSocketthat capssend()at 4KB per call. The Python-level slicing loop now runs ~1024 times against a 4MB payload, so any change to that loop is the dominant cost of the bench.buffer = buffer[n:]toview = view[n:](the perf: use memoryview in write() to avoid copies #954 change) moves this bench from ~13.8ms to <1µs - far above any walltime noise floor.Test plan
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.