Fix mypy errors with newer pandas-stubs #11066
Open
+42
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
force-pushed
the
mypy
branch
4 times, most recently
from
28ffc54 to
c344162
Compare
Remove the pandas-stubs version pin (<=2.2.3.241126) and fix the mypy errors that appear with newer versions. This resolves pydata#10110. Changes by category: 1. Added type: ignore comments with explanatory notes for cases where pandas-stubs is stricter than actual pandas behavior: - CFTimeIndex.__add__/__radd__ return Self instead of overloaded types - Index.get_indexer accepts ndarray/list, not just Index - CategoricalIndex.remove_unused_categories missing from stubs - Series.where accepts broader argument types - ExtensionArray.astype accepts ExtensionDtype - Series[datetime].__setitem__ accepts np.nan (converts to NaT) - MultiIndex.rename accepts list of names 2. Added explicit type annotations to help mypy infer correct types: - coordinates.py: codes as list[np.ndarray] - dataset.py: arrays and extension_arrays list types - indexes.py: xr_index variable with PandasIndex | PandasMultiIndex 3. Removed redundant casts and fixed variable shadowing: - Removed unnecessary cast in remove_unused_levels_categories - Converted dict_keys to list for reorder_levels - Fixed test_backends.py variable naming (tdf -> tdf_series) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
fixes #10110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added type: ignore with explanations for:
CFTimeIndex.__add__/__radd__- return Self instead of pandas overloaded typesIndex.get_indexer- accepts ndarray/list, not just IndexCategoricalIndex.remove_unused_categories- missing from stubsSeries.where- accepts broader argument types than stubs allowExtensionArray.astype- accepts ExtensionDtypeSeries[datetime].__setitem__- accepts np.nan (converts to NaT)MultiIndex.rename- accepts list of namesAdded explicit type annotations:
coordinates.py: codes aslist[np.ndarray]dataset.py: arrays and extension_arrays list typesindexes.py: newxr_indexvariable withPandasIndex | PandasMultiIndextypeCleanup:
remove_unused_levels_categoriesreorder_levelstdf→tdf_series)Test plan
uv run dmypy runpasses with 0 errorspre-commit run --all-filespassesuv run pytest xarray -n auto- all tests pass🤖 Generated with Claude Code