Skip to content

Fix CapacityLimiter._pending_borrowers leak on non-Cancelled exceptions #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bysiber wants to merge 1 commit into from
+2 −2
Closed

Fix CapacityLimiter._pending_borrowers leak on non-Cancelled exceptions #3399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/trio/_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ async def acquire_on_behalf_of(self, borrower: Task | object) -> None:
self._pending_borrowers[task] = borrower
try:
await self._lot.park()
except trio.Cancelled:
self._pending_borrowers.pop(task)
except BaseException:
Copy link
Contributor

@A5rocks A5rocks Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KI cannot be raised here because we are in a @enable_ki_protection function.

self._pending_borrowers.pop(task, None)
raise
else:
await trio.lowlevel.cancel_shielded_checkpoint()
Expand Down
Loading