Skip to content

Ensure new_cmd is always defined #20510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 1 commit into from
Jan 1, 2026
Merged

Ensure new_cmd is always defined #20510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mypyc/build_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@


def spawn(self, cmd, **kwargs) -> None: # type: ignore[no-untyped-def]
new_cmd = list(cmd)
if PYODIDE:
new_cmd = list(cmd)
for argument in reversed(new_cmd):
if not str(argument).endswith(".c"):
continue
Expand All @@ -50,7 +50,6 @@ def spawn(self, cmd, **kwargs) -> None: # type: ignore[no-untyped-def]
elif not NO_EXTRA_FLAGS:
compiler_type: str = self.compiler_type
extra_options = EXTRA_FLAGS_PER_COMPILER_TYPE_PER_PATH_COMPONENT.get(compiler_type, None)
new_cmd = list(cmd)
if X86_64 and extra_options is not None:
# filenames are closer to the end of command line
for argument in reversed(new_cmd):
Expand Down
3 changes: 1 addition & 2 deletions mypyc/lib-rt/build_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@


def spawn(self, cmd, **kwargs) -> None: # type: ignore[no-untyped-def]
new_cmd = list(cmd)
if PYODIDE:
new_cmd = list(cmd)
for argument in reversed(new_cmd):
if not str(argument).endswith(".c"):
continue
Expand All @@ -50,7 +50,6 @@ def spawn(self, cmd, **kwargs) -> None: # type: ignore[no-untyped-def]
elif not NO_EXTRA_FLAGS:
compiler_type: str = self.compiler_type
extra_options = EXTRA_FLAGS_PER_COMPILER_TYPE_PER_PATH_COMPONENT.get(compiler_type, None)
new_cmd = list(cmd)
if X86_64 and extra_options is not None:
# filenames are closer to the end of command line
for argument in reversed(new_cmd):
Expand Down