PEP 750: Updates after community feedback#4124
Conversation
Next round of updates to PEP 750
gvanrossum-ms
left a comment
There was a problem hiding this comment.
I was going to do a full review of this PR but ran out of time. Here are a few comments I have. In any case, I offer to just merge this PR, so readers of the thread won't have to wonder if their changes are accepted. You can always merge another PR -- there's no particular process to be followed here.
…o pep750-october-updates
AA-Turner
left a comment
There was a problem hiding this comment.
Thank you for the reminder to review! Nothing particularly major, though a few questions:
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…o pep750-october-updates
Thanks for all the good catches @AA-Turner -- I think I've addressed all of these. Let me know how things look! |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
left a comment
There was a problem hiding this comment.
Thank you! Are you waiting for any further reviews of this PR, or would you like for it to be merged?
A
Happy to have it merged! Thanks again for all your help. |
Updates include:
Template, includingstrings,interpolations, andvalues.Template.__hash__()Template.argsexplicitly be atupleThanks to @lysnikolaou @koxudaxi @pauleveritt @jimbaker and everyone in recent discussion threads for all the useful feedback.
I opened a new Discourse thread for this updated PR.
📚 Documentation preview 📚: https://pep-previews--4124.org.readthedocs.build/