Merged
Conversation
Member
|
docs.python.org needs one too but I'm unsure how to implement it. The package sphinx-notfound-page is broken so I guess we just create a simple html page that can be added to the nginx conf. |
Member
Author
Let's continue that in python/cpython#125895 |
AA-Turner
approved these changes
Dec 31, 2024
Member
AA-Turner
left a comment
There was a problem hiding this comment.
I remember we initially had problems with a custom 404 page due to redirects to PEP 404, but this is now done proxy-side with the TF config, so hopefully there won't be problems now.
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Member
Author
|
There we go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if you typo a PEP (e.g. https://peps.python.org/pep-123456) you get the default GitHub Pages 404 page:
This is an attempt to use a nicer one using our own Sphinx theme:
I have this on my fork right now: https://hugovk.github.io/peps/pep-123456
The one difference is I have
notfound_urls_prefix = "/peps/"inconf.pybecause it's using the github.io domain and apeps/subdir. See:https://sphinx-notfound-page.readthedocs.io/en/latest/faq.html#does-this-extension-work-with-github-pages
We'll probably need to merge this to see if it works properly.
📚 Documentation preview 📚: https://pep-previews--4184.org.readthedocs.build/