Remove trailing slashes from intersphinx inventory URLs#4239
Closed
Viicos wants to merge 1 commit intopython:mainfrom
Closed
Remove trailing slashes from intersphinx inventory URLs#4239Viicos wants to merge 1 commit intopython:mainfrom
Viicos wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
I think this is a bug in Sphinx 8.1 that is fixed in 8.2. I will check (if so, we don't need to merge this) |
Contributor
Author
|
You mean Sphinx will check if there's a trailing slash, and conditionally append |
Member
|
Yes, it's a Sphinx 8.0 bug fixed in Sphinx 8.1 -- I know because at one point I was going to submit a PR to fix it in Sphinx but saw it had already been fixed :) We need to resolve #4087 before moving to 8.1+. |
Member
|
sphinx-doc/sphinx#12782 / sphinx-doc/sphinx#12807 is the Sphinx 8.1.0 fix. |
Contributor
Author
|
Thanks @AA-Turner @hugovk, I'll close this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the Sphinx output:
📚 Documentation preview 📚: https://pep-previews--4239.org.readthedocs.build/