PEP 781: Make TYPE_CHECKING a built-in constant#4318
Merged
AA-Turner merged 13 commits intopython:mainfrom Mar 28, 2025
Merged
Conversation
hugovk
reviewed
Mar 24, 2025
Member
hugovk
left a comment
There was a problem hiding this comment.
Thank you for the PEP!
I've added the new PEP checklist to the PR description, please could you check things off as appropriate?
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AA-Turner
reviewed
Mar 25, 2025
Member
AA-Turner
left a comment
There was a problem hiding this comment.
Editorial/review comments, I'll also comment on the Discouse thread with more substantive points.
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
reviewed
Mar 26, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk
reviewed
Mar 26, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AA-Turner
reviewed
Mar 26, 2025
hugovk
approved these changes
Mar 26, 2025
TYPE_CHECKING builtin constant
TYPE_CHECKING builtin constantTYPE_CHECKING builtin
AA-Turner
reviewed
Mar 27, 2025
Member
AA-Turner
left a comment
There was a problem hiding this comment.
Editorial/grammatical suggestions:
AA-Turner
reviewed
Mar 27, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Vincent Poulailleau <vpoulailleau@gmail.com>
TYPE_CHECKING builtinTYPE_CHECKING a built-in constant
AA-Turner
approved these changes
Mar 28, 2025
Member
|
Read the docs is failing with " fatal: reference is not a tree", but everything else is passing. A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://discuss.python.org/t/pep-781-adding-type-checking-constant/85728
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4318.org.readthedocs.build/pep-0781/