Merged
Conversation
AA-Turner
reviewed
Mar 28, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
freakboy3742
requested changes
Apr 1, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
reviewed
Apr 2, 2025
AA-Turner
reviewed
Apr 2, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
juntyr
reviewed
Apr 4, 2025
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
hugovk
reviewed
Apr 6, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742
approved these changes
Apr 7, 2025
Contributor
freakboy3742
left a comment
There was a problem hiding this comment.
This is looking good to me. There's still some finalisation work to be done on the actual Pyodide ABI spec, but that's a living document by definition, so I don't think it needs to hold up anything here.
Contributor
Author
|
Thanks again @AA-Turner @freakboy3742 @hugovk and @juntyr for your reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @pfmoore.
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4328.org.readthedocs.build/pep-0783/