PEP 743: Make the macro a simple boolean

[vstinner]

Remove the version value.

---

📚 Documentation preview 📚: https://pep-previews--4595.org.readthedocs.build/

[vstinner]

cc @encukou

[erlend-aasland]

We should also reconsider the name of the macro. Py_COMPAT_API_VERSION is a bit misleading now that there is no specific version involved. Alyssa suggested Py_RECOMMENDED_API earlier. Maybe Py_HIDE_DEPRECATED_API?

[vstinner]

We should also reconsider the name of the macro. Py_COMPAT_API_VERSION is a bit misleading now that there is no specific version involved. Alyssa suggested Py_RECOMMENDED_API earlier. Maybe Py_HIDE_DEPRECATED_API?

Oh right! Since the PEP creates legacy.h, maybe the macro can be called Py_OMIT_LEGACY_API?

[erlend-aasland]

I like Py_OMIT_LEGACY_API!

[vstinner]

Ok, let me rename the macro to Py_OMIT_LEGACY_API.

[vstinner]

@encukou: Would you mind to review the PEP update? Does it look good to you?

[zooba]

Thanks for the changes, it looks good to me (but I'm not the coauthor, so I understand why you're waiting on Petr).

[AA-Turner]

It might be prudent to add a brief mention of the now-removed Py_COMPAT_API_VERSION in Rejected Ideas?

Otherwise, looks good editorially.

A

[encukou]

I'd add the implication of not having a versioned macro to Backwards Compatibility; otherwise the change looks fine to me. Thanks!

[vstinner]

Merged, thank you for reviews.

It might be prudent to add a brief mention of the now-removed Py_COMPAT_API_VERSION in Rejected Ideas?

I don't think that it's worth it.