PEP 791: edits (address SC feedback)#4639
Conversation
|
N/B: This extends I'll wait for more feedback in the d.p.o thread, then make this ready for review. |
|
You should also update the PEP to use |
I'm not sure. IMO, this should be postponed till final resolution of the SC. On one hand, SC preference was expressed sufficiently clear. On another hand, this will also require adjustment in the implementation. That might be a waste of work. I think it's clear that it's a minor point and that decision on module naming - left to SC. |
|
SC expressed a strong preference for |
9d413e3 to
48caa4b
Compare
7e51943 to
7d26e47
Compare
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
@skirpichev: Tell me when it's ready to be merged.
Oh, forgot to reply. BTW, when my pr is ready to review - it's ready to be merged. On my taste, of course. |
|
Ok, I merged your PR. |
|
You may add a comment to python/steering-council#310 and the discussion to say that the PEP has been updated to address SC's feedback. |
* New namespace avoid name clash with existing math's stuff * Mention pitfails of c_div() implementation * Clarify what IDE means * Rephrase Rationale * intmath -> math.integer
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4639.org.readthedocs.build/
https://pep-previews--4639.org.readthedocs.build/pep-0791/