[stdlib] Add default values part 2 #14769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stdlib/os/__init__.pyi
Outdated
| setsid: bool = False, | ||
| setsigmask: Iterable[int] = (), | ||
| setsigdef: Iterable[int] = (), | ||
| scheduler: tuple[Any, sched_param] | None = ..., |
Member
There was a problem hiding this comment.
I think the | None part here is wrong: it must be a tuple if supplied.
Contributor
Author
There was a problem hiding this comment.
Attempting to pass None to scheduler (raises on 3.15 and 3.9):
SystemError: new style getargs format but argument is not a tuple
Member
There was a problem hiding this comment.
Attempting to pass
Nonetoscheduler(raises on 3.15 and 3.9):SystemError: new style getargs format but argument is not a tuple
Oh, uh, I think you found a CPython bug there?
Member
There was a problem hiding this comment.
Yes, a SystemError indicates a CPython bug.
Contributor
Author
There was a problem hiding this comment.
I opened an issue 👍
JelleZijlstra
approved these changes
Jan 11, 2026
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, noticed some further suggestions
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Jan 11, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faulthandler- https://github.com/python/cpython/blob/main/Modules/faulthandler.chashlib- generic constructor, but all other functions haveusedforsecurity=Trueitertools.count- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/itertoolsmodule.c#L3388itertools.accumulate- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/itertoolsmodule.c#L2981itertools.islice- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/itertoolsmodule.c#L1510itertools.zip_longest- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/itertoolsmodule.c#L3908itertools.permutations- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/itertoolsmodule.c#L2738multiprocessing- taken from parent classpickle.Pickler.__init__(self, file: SupportsWrite[bytes], protocol: int | None = None, ...)os.fdopen- arguments are passed toio.open, whose signature, judging by typeshed, is the same asbuiltins.openos.posix_spawn- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/posixmodule.c#L7597os.posix_spawnp- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/posixmodule.c#L7643os.copy_file_range- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/posixmodule.c#L12501os.pidfd_open- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/posixmodule.c#L10285os.splice- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/posixmodule.c#L12565pstats.Stats- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Lib/pstats.py#L110sched.scheduler- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Lib/sched.py#L53ssl- even though default values use constants "aliases", I used enum values to work around flake8 errors. I also moved the functions below so that these objects are defined.syslog.openlog- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Modules/syslogmodule.c#L141timeit.Timer- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Lib/timeit.py#L101C57-L101C70timeit.timeit- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Lib/timeit.py#L231timeit.repeat- https://github.com/python/cpython/blob/8cfd7b4ecf9c01ca2bea57fe640250f716cb6ee3/Lib/timeit.py#L237zipfile- default values are taken fromio.TextIOWrapperinto which all arguments are passed