Skip to content

[sre_compile] Use TypeGuard for isstring #15250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 3 commits into from
Jan 10, 2026
Merged

[sre_compile] Use TypeGuard for isstring #15250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d451794
[sre_compile] Use TypeGuard for isstring
donbarbos Jan 10, 2026
da5179c
Retain knowledge about str,bytes types
donbarbos Jan 10, 2026
51071a5
merge into one overload
donbarbos Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions stdlib/sre_compile.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ from re import Pattern
from sre_constants import *
from sre_constants import _NamedIntConstant
from sre_parse import SubPattern
from typing import Any, Final
from typing import Any, Final, Literal, overload
from typing_extensions import TypeGuard

MAXCODE: Final[int]

def dis(code: list[_NamedIntConstant]) -> None: ...
def isstring(obj: Any) -> bool: ...
@overload
def isstring(obj: str | bytes) -> Literal[True]: ...
@overload
def isstring(obj: object) -> TypeGuard[str | bytes]: ...
def compile(p: str | bytes | SubPattern, flags: int = 0) -> Pattern[Any]: ...