use memory mapping to accelerate hashing of large models.#340
Open
rfletchr wants to merge 2 commits intopythongosssss:mainfrom
Open
use memory mapping to accelerate hashing of large models.#340rfletchr wants to merge 2 commits intopythongosssss:mainfrom
rfletchr wants to merge 2 commits intopythongosssss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change optimizes the hashing of checkpoint files using memory mapping.
Essentially this makes file I/O far more efficient and allows the hasher to run extremely quickly.
A SDXL checkpoint was taking roughly 30 seconds to hash using the original implementation, this is reduced to about 6 seconds with memory mapping.
This could be accelerated further by switching to a non cryptographic hash like blake3 which is extremely fast, and supports multithreading.