patch: apply menu updates for relevant types only#462
Open
pintza wants to merge 1 commit intopythongosssss:mainfrom
Open
patch: apply menu updates for relevant types only#462pintza wants to merge 1 commit intopythongosssss:mainfrom
pintza wants to merge 1 commit intopythongosssss:mainfrom
Conversation
Owner
|
Hi, this will cause a noticable delay in rendering the menu (set combo mode to e.g. tree, click widget, see original context menu, then see it convert to tree), and looks like it will also break reloading the list What performance issues are you seeing causing it to slowdown startup when preloading the image list? |
Author
|
I’m using remote storage for my models, and each lookup for a missing file ends up being quite heavy. I totally get that deferring the lookup might add a delay when opening the menu, but right now, even without using the menu at all, just having this repo added as a custom node noticeably slows down the UI on startup. That’s what I was hoping to avoid with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
The changes optimize performance by ensuring that only the necessary image data is loaded when displaying checkpoints or loras in the menu.
These optimizations are particularly beneficial when dealing with large checkpoint or lora remote libraries, as they reduce unnecessary networking and accelerate the ComfyUI GUI load.