Arm backend: Move import in DecomposePermuteForU55Pass#19331
Open
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Move import in DecomposePermuteForU55Pass#19331AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
Conversation
Importing on top-level causes a dependency cycle Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I166af41c1019b9a5590e69706bdb4ed2c2fb6988
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19331
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 1 New Failure, 1 Cancelled Job, 11 Unrelated FailuresAs of commit 86fef38 with merge base 1debeb6 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Arm backend’s DecomposePermuteForU55Pass to avoid a circular dependency by moving the EthosUCompileSpec import from module scope into the specific helper method that uses it.
Changes:
- Removed the top-level import of
EthosUCompileSpec. - Added a lazy (function-local) import of
EthosUCompileSpecinside_violates_exact_constraint()to break the dependency cycle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+114
to
119
| # Lazy import to avoid circular dependency | ||
| from executorch.backends.arm.ethosu.compile_spec import EthosUCompileSpec | ||
|
|
||
| if dtype not in (torch.int8, torch.bool, torch.int16): | ||
| return True | ||
|
|
zingo
approved these changes
May 6, 2026
digantdesai
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing on top-level causes a dependency cycle
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell