Skip to content

Arm backend: Promote InsertDataLayoutCastsPass up pass list#19332

Open
tom-arm wants to merge 1 commit intopytorch:mainfrom
tom-arm:promote_pass
Open

Arm backend: Promote InsertDataLayoutCastsPass up pass list#19332
tom-arm wants to merge 1 commit intopytorch:mainfrom
tom-arm:promote_pass

Conversation

@tom-arm
Copy link
Copy Markdown
Collaborator

@tom-arm tom-arm commented May 6, 2026

  • Move above Aten -> TOSA transforms to ensure dtypes are valid

Change-Id: I021289f51f75e1a303050d0ffcf3b939f67ee88f

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

* Move above Aten -> TOSA transforms to ensure dtypes are valid

Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: I021289f51f75e1a303050d0ffcf3b939f67ee88f
@tom-arm tom-arm requested a review from digantdesai as a code owner May 6, 2026 13:47
Copilot AI review requested due to automatic review settings May 6, 2026 13:47
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19332

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 10 Unrelated Failures

As of commit 09c0efb with merge base 1debeb6 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 6, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2026
@tom-arm tom-arm added the release notes: none Do not include this in the release notes label May 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Arm backend TOSA lowering pipeline ordering so InsertDataLayoutCastsPass runs before the Aten→TOSA rewrite passes, ensuring unsupported dtypes for data-layout ops are cast to a spec-supported dtype prior to transformation.

Changes:

  • Moved InsertDataLayoutCastsPass() from the postprocessing/cleanup block to the end of the pre Aten→TOSA transformation pass block.
  • As a result, dtype-correction casts are inserted while the graph still contains the targeted Aten ops (e.g., cat, view_copy, permute_copy, slice_copy, etc.).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants