Conversation
Fixing broken link per issue #3784
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3786
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee73287 with merge base 3e6cc9b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Claude finished @sekyondaMeta's task in 1m 6s —— View job Review of PR #3786
This PR makes two changes to Change 1 (line 46): Removed broken TorchTitan config link The link to
This is a reasonable fix — removing a broken link is better than leaving it. That said, the original text provided a concrete example ( Change 2 (line 449): Added missing newline at end of file The file previously had no trailing newline ( VerdictThe changes look correct and straightforward. LGTM. One minor suggestion: if you know the new location of the debug model config in TorchTitan, consider adding a link to the updated path to preserve the helpful example reference for users. |
|
@amirafzali I cant seem to find the new location of the file, do you have a suggestion of another file/example? |
Fixing broken link per issue #3784