Skip to content

Update monarch_distributed_tutorial.rst#3786

Open
sekyondaMeta wants to merge 2 commits intomainfrom
fixBrokenLinks3_2_26
Open

Update monarch_distributed_tutorial.rst#3786
sekyondaMeta wants to merge 2 commits intomainfrom
fixBrokenLinks3_2_26

Conversation

@sekyondaMeta
Copy link
Contributor

Fixing broken link per issue #3784

Fixing broken link per issue #3784
@sekyondaMeta sekyondaMeta requested a review from amirafzali March 2, 2026 15:02
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3786

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ee73287 with merge base 3e6cc9b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the cla signed label Mar 2, 2026
@sekyondaMeta
Copy link
Contributor Author

@claude

@claude
Copy link

claude bot commented Mar 2, 2026

Claude finished @sekyondaMeta's task in 1m 6s —— View job


Review of PR #3786

  • Gather context and read changed files
  • Review the link changes
  • Post review feedback

This PR makes two changes to intermediate_source/monarch_distributed_tutorial.rst:

Change 1 (line 46): Removed broken TorchTitan config link

The link to https://github.com/pytorch/torchtitan/blob/main/torchtitan/models/llama3/train_configs/debug_model.toml was removed. This is likely a 404 because the TorchTitan repo has reorganized its config paths. The line now reads:

  1. A valid Titan model config and tokenizer in your working directory

This is a reasonable fix — removing a broken link is better than leaving it. That said, the original text provided a concrete example (debug_model.toml) which was helpful for users. If there's a new valid path for the config file, it would be worth linking to it instead. But if the file has been removed/moved without a clear replacement, removing the link is the right call.

Change 2 (line 449): Added missing newline at end of file

The file previously had no trailing newline (\ No newline at end of file). This is now fixed. Good housekeeping.

Verdict

The changes look correct and straightforward. LGTM. One minor suggestion: if you know the new location of the debug model config in TorchTitan, consider adding a link to the updated path to preserve the helpful example reference for users.


@sekyondaMeta
Copy link
Contributor Author

@amirafzali I cant seem to find the new location of the file, do you have a suggestion of another file/example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant