Skip to content

ci: fix remaining GitHub Actions on Node 20#634

Merged
estebany-qd merged 1 commit into
mainfrom
ci/estebany/fix-remaining-node24
May 22, 2026
Merged

ci: fix remaining GitHub Actions on Node 20#634
estebany-qd merged 1 commit into
mainfrom
ci/estebany/fix-remaining-node24

Conversation

@estebany-qd
Copy link
Copy Markdown
Contributor

Follow-up to the bulk Node 24 migration. cache@v3.5.0 SHA was missed in the first pass.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the GitHub Actions CI workflow to pin the actions/cache step to a newer version (v5.0.5) instead of v3.5.0. The change is isolated to line 18 of .github/workflows/ci.yml in the deploy job, with no modifications to workflow logic or other steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • qdrant/fastembed#633: Updates the same CI workflow file to bump actions/cache and other GitHub Actions dependencies to newer versions.

Suggested reviewers

  • joein
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating a GitHub Actions step that was missed during a Node 24 migration.
Description check ✅ Passed The description is directly related to the changeset, explaining the context as a follow-up to a bulk Node 24 migration where a cache action SHA was missed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/estebany/fix-remaining-node24

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Line 18: Confirm that the pinned actions/cache SHA
(actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae) is intentionally set to
v5.0.5; update any PR or workflow comments that claim "Node 20" to reflect that
actions/cache v5 runs using node24 (runs.using: node24), and while you’re here,
review the actions/cache v5 release/migration notes for behavioral changes from
v3.5.0 to v5.0.5 and adjust the workflow/cache configuration or documentation
accordingly (search for uses: actions/cache and any Node-version messaging in
the PR).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d1242be-448a-4fa9-ac01-bca4eafa471f

📥 Commits

Reviewing files that changed from the base of the PR and between fde1e0b and 65280d1.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml
@estebany-qd estebany-qd enabled auto-merge (squash) May 21, 2026 21:54
@estebany-qd estebany-qd merged commit a499c31 into main May 22, 2026
13 checks passed
@estebany-qd estebany-qd deleted the ci/estebany/fix-remaining-node24 branch May 22, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants