add Python 3.13t support#5
Conversation
|
there's an open PR (huggingface/tokenizers#1774) for tokenizers which adds 3.13t support. after that gets merged this PR will make fastembed 3.13t compatible |
|
Merged! |
|
This looks like this fixes a segfault on Python 3.14 (a default build), or at least pulling in this PR does not segfault compared to the latest commit on |
|
I can confirm this fixes the Python 3.14 segfault I was getting. I've tested the pyo3 0.25 upgrade against fastembed and it works. Would love to see this reviewed and merged alongside PR #7's 3.14 matrix addition. |
|
@electroglyph Hi, Is it still in progress? |
nope, i used it for a long time without error. i kinda forgot about this tbh. i'm just getting back into qdrant and building all the crap i need for free-threaded, i'll bump pyo again and see what happens. if it's fine i'll commit it edit: i haven't looked at the workflow in a year, so merge it with caution, or look at one of the newer PRs |
I haven't been using Fastembed lately, but decided to replace my little ONNX wrapper with Fastembed just to tidy it up.
that's when I noticed that Fastembed silently dies on import in Python 3.13t, so here's the fix I'm currently using.
this PR:
moves Fastembed closer to Python 3.13t compatibility
updates pyo3 dependency to support Python 3.13t
slightly updates Rust code
updates (unused?) test
tested on Python 3.12 and Python 3.13.3+ free-threaded.
closes #4
edit: I haven't tested the workflow, but I looked at the Github actions before I updated the workflow, and my changes should be fine.