fix: resolve Python 3.14 SegFault and modernize PyO3 implementation#9
Open
ElissonRodrigues wants to merge 16 commits into
Open
fix: resolve Python 3.14 SegFault and modernize PyO3 implementation#9ElissonRodrigues wants to merge 16 commits into
ElissonRodrigues wants to merge 16 commits into
Conversation
7604981 to
74ab785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the Segmentation Fault occurring on Python 3.14.3 during stemmer initialization and modernizes the overall Rust-Python interface. It also introduces type stubs for better developer experience.
Context
This PR addresses the root cause of the Segmentation Fault reported in qdrant/fastembed#618 when running on Python 3.14. While the issue was observed in
fastembed, the underlying crash occurs within thepy_rust_stemmersextension during initialization.Key Changes
panic!intoPyResult<Self>in theSnowballStemmerconstructor. Invalid language inputs now raise a standardValueErrorin Python instead of crashing the process..pyi) and thepy.typedmarker (PEP 561) to enable autocompletion and type checking in IDEs and linters.TypeErrorinspeedtest.pyrelated to Python 3 string/bytes handling in the comparison baseline.Verification
tests/test_py_rust_stemmers.py).speedtest.pyandbenchmark_for_quantile.py) verified for performance parity.Performance
The Rust implementation remains ~35x-40x faster than the pure Python
snowballstemmerbaseline on modern large-scale benchmarks.