fix: improve screen events reliability - flush on close, handle 2xx/4xx, add event_uid#784
Open
shameondev wants to merge 2 commits intomainfrom
Open
fix: improve screen events reliability - flush on close, handle 2xx/4xx, add event_uid#784shameondev wants to merge 2 commits intomainfrom
shameondev wants to merge 2 commits intomainfrom
Conversation
…xx correctly, add event_uid
SpertsyanKM
reviewed
Mar 16, 2026
| } | ||
| } else { | ||
| serializer.deserialize(responsePayload) | ||
| } |
Contributor
There was a problem hiding this comment.
I'm afraid this can break the current logic anyhow. I'm not sure that falling back to an empty map in several cases is a good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onScreenClosed()now callsflush()after tracking screen_closed)event_uidper event intrack()for deduplicationContext
Part of Screen Events Reliability initiative (5 repos). Ships with next SDK release (Phase B).
Files changed
NetworkClientImpl.kt— wrap deserialize in try-catch for 2xxScreenEventsServiceImpl.kt— 4xx no-rebuffer, event_uid generationScreenPresenter.kt— flush on screen closeTest plan